netdev - Re: [PATCH] ks8851_ml ethernet network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Sep 2009 20:48:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	greg@...ah.com
Cc:	netdev@...r.kernel.org, Charles.Li@...rel.Com, Choi@...ah.com,
	David.Choi@...rel.Com, jgarzik@...hat.com, shemminger@...tta.com
Subject: Re: [PATCH] ks8851_ml ethernet network driver

From: Greg KH <greg@...ah.com>
Date: Wed, 16 Sep 2009 19:38:36 -0700

> From: Choi, David <David.Choi@...rel.Com>
> 
> This is a network driver for the ks8851 16bit MLL ethernet device.
> 
> Signed-off-by: David J. Choi <david.choi@...rel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

This doesn't even build cleanly:

drivers/net/ks8851_mll.c: In function ‘ks_inblk’:
drivers/net/ks8851_mll.c:555: warning: cast from pointer to integer of different size
drivers/net/ks8851_mll.c:558: warning: passing argument 1 of ‘_readw’ makes pointer from integer without a cast
drivers/net/ks8851_mll.c: In function ‘ks_outblk’:
drivers/net/ks8851_mll.c:571: warning: cast from pointer to integer of different size
drivers/net/ks8851_mll.c:574: warning: passing argument 2 of ‘_writew’ makes pointer from integer without a cast

It also has a big "#define DEBUG" at the beginning of the driver.

And it also has stuff like:

+#define MALLOC(x)		kmalloc(x, GFP_KERNEL)

which actually decreases the readability of this driver.

Please fix this up.