lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Sep 2009 15:18:35 -0700 From: Herbert Xu <herbert@...dor.apana.org.au> To: Thomas Graf <tgraf@...radead.org> Cc: davem@...emloft.net, eric.dumazet@...il.com, shemminger@...tta.com, jesse.brandeburg@...il.com, hawk@...u.dk, netdev@...r.kernel.org Subject: Re: [RFC] skb align patch Thomas Graf <tgraf@...radead.org> wrote: > > As I pointed out to Herbert already, this alignment change may actually > make things worse or even break things as long as compare_ether_header() > used in __napi_gro_receive() expects the IP header to be aligned to 4 > bytes. That can be fixed of course, just wanted to mention it. Well this particular patch doesn't because x86-64 is fine with unaligned access :) But yeah we need to fix up GRO to not do that for other arches. It's on my list. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists