netdev - Re: [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in update_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Oct 2009 21:53:50 +0200
From:	Manuel Lauss <manuel.lauss@...glemail.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>,
	manuel.lauss@...il.com, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] au1000_eth: Duplicate test of RX_OVERLEN bit in 
	update_rx_stats()

On Tue, Oct 6, 2009 at 9:54 PM, Roel Kluin <roel.kluin@...il.com> wrote:
> in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT.
> in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> please review, I merely guessed it should be RX_RUNT.
>
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index fdf5937..04f63c7 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -721,7 +721,7 @@ static inline void update_rx_stats(struct net_device *dev, u32 status)
>                ps->rx_errors++;
>                if (status & RX_MISSED_FRAME)
>                        ps->rx_missed_errors++;
> -               if (status & (RX_OVERLEN | RX_OVERLEN | RX_LEN_ERROR))
> +               if (status & (RX_OVERLEN | RX_RUNT | RX_LEN_ERROR))
>                        ps->rx_length_errors++;
>                if (status & RX_CRC_ERROR)
>                        ps->rx_crc_errors++;
> @@ -794,8 +794,6 @@ static int au1000_rx(struct net_device *dev)
>                                        printk("rx len error\n");
>                                if (status & RX_U_CNTRL_FRAME)
>                                        printk("rx u control frame\n");
> -                               if (status & RX_MISSED_FRAME)
> -                                       printk("rx miss\n");

Yeah, looks right.

Acked-by: Manuel Lauss <manuel.lauss@...il.com>

       Manuel Lauss
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html