netdev - RE: [PATCH] netxen: Fix Unlikely(x)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Oct 2009 22:34:39 -0700
From:	Dhananjay Phadke <dhananjay.phadke@...gic.com>
To:	Roel Kluin <roel.kluin@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: RE: [PATCH] netxen: Fix Unlikely(x) > y

Oh sure, that was a typo. Thanks for catching it. 

Acked-by: Dhananjay Phadke <dhananjay@...xen.com>

-----Original Message-----
From: Roel Kluin [mailto:roel.kluin@...il.com] 
Sent: Tuesday, October 06, 2009 06:24
To: Dhananjay Phadke; netdev@...r.kernel.org; Andrew Morton
Subject: [PATCH] netxen: Fix Unlikely(x) > y

The closing parenthesis was not on the right location.

Signed-off-by: Roel Kluin <roel.kluin@...il.com>
---
This was intended, I think?

diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index b5aa974..9b9eab1 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1714,7 +1714,7 @@ netxen_nic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
 	/* 4 fragments per cmd des */
 	no_of_desc = (frag_count + 3) >> 2;
 
-	if (unlikely(no_of_desc + 2) > netxen_tx_avail(tx_ring)) {
+	if (unlikely(no_of_desc + 2 > netxen_tx_avail(tx_ring))) {
 		netif_stop_queue(netdev);
 		return NETDEV_TX_BUSY;
 	}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html