netdev - Re: [PATCH] atm: Cleanup redundant tests on unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Oct 2009 18:08:30 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Roel Kluin <roel.kluin@...il.com>
CC:	Chas Williams <chas@....nrl.navy.mil>, netdev@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] atm: Cleanup redundant tests on unsigned

Roel Kluin a écrit :
> The variables are unsigned so the `< 0' test always fails, the
> other part of the test catches wrapped values.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---

I believe such patches were posted in the past.

General consensus is that compiler is able to do this optimization for us,
and reader doesnt have to ask to himself : "Is the test safe enough ?"

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html