lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2009 07:41:26 +0000 From: Jarek Poplawski <jarkao2@...il.com> To: Johannes Berg <johannes@...solutions.net> Cc: Tilman Schmidt <tilman@...p.cc>, David Miller <davem@...emloft.net>, hidave.darkstar@...il.com, linux-kernel@...r.kernel.org, tglx@...utronix.de, linux-wireless@...r.kernel.org, linux-ppp@...r.kernel.org, netdev@...r.kernel.org, paulus@...ba.org, Michael Buesch <mb@...sch.de>, Oliver Hartkopp <oliver@...tkopp.net> Subject: Re: [PATCH] net: Adjust softirq raising in __napi_schedule On Fri, Oct 23, 2009 at 04:46:31PM +0200, Johannes Berg wrote: > On Fri, 2009-10-23 at 16:39 +0200, Tilman Schmidt wrote: > > > Strange. Then what are the two separate functions netif_rx() and > > netif_rx_ni() for? > > netif_rx_ni() disables preemption. You wrote earlier: > [...] the networking layer needs to have > packets handed to it with softirqs disabled. How disabling preemption can fix something which needs softirqs disabled? Could you be more precise? > > > This really should be obvious. You're fixing the warning at the source > > > of the warning, rather than the source of the problem. > > > > Good idea. So please do tell us where the source of the problem is. > > You use netif_rx_ni() instead of netif_rx() at whatever place that > causes this problem. This isn't a very precise description either. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists