netdev - Re: [PATCH] PPPoE: Fix flush/close races.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Oct 2009 22:59:33 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Michal Ostrowski <mostrows@...il.com>
Cc:	linux-ppp@...r.kernel.org, netdev <netdev@...r.kernel.org>,
	Denys Fedoryschenko <denys@...p.net.lb>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH] PPPoE: Fix flush/close races.

[Michal Ostrowski - Mon, Oct 26, 2009 at 02:51:52PM -0500]
| Be more careful about the state of pointers during tear-down.
| The "pppoe_dev" field can only be looked at safely while holding socket locks.
| This subsequently allows for the flush_lock to be killed.
| 
| We depend on the PPPOX_CONNECTED state to tell us that that those fields are
| valid, so whoever clears that state (pppox_unbind_sock()) is responsible for
| the dev_put() call.
| 
| We also have to ensure that we delete_item() on all sockets before they are
| cleaned up.
| 
| The need for these changes has been exposed by scenarios wherein namespace
| bindings of ethernet devices change while there are ongoing PPPoE sessions,
| which resulted in oopses due to unusual socket connection termination paths,
| exposing these issues.
| 
| Signed-off-by: Michal Ostrowski <mostrows@...il.com>
| Reviewed-by: Cyril Gorcunov <gorcunov@...il.com>
...

Thanks a lot Michal!

I think we should add as well

Reported-by: Denys Fedoryschenko <denys@...p.net.lb>
Tested-by: Denys Fedoryschenko <denys@...p.net.lb>

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html