netdev - Re: [PATCH net-next-2.6] bnx2: avoid compiler warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Nov 2009 05:08:13 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] bnx2: avoid compiler warnings

From: "Michael Chan" <mchan@...adcom.com>
Date: Tue, 3 Nov 2009 10:01:34 -0800

> 
> On Tue, 2009-11-03 at 01:17 -0800, Eric Dumazet wrote:
>> drivers/net/bnx2.c: In function ‘bnx2_enable_forced_2g5’:
>> drivers/net/bnx2.c:1447: warning: ‘bmcr’ may be used uninitialized in this function
>> drivers/net/bnx2.c: In function ‘bnx2_disable_forced_2g5’:
>> drivers/net/bnx2.c:1482: warning: ‘bmcr’ may be used uninitialized in this function
>> 
>> One fix would be to have an initial value, but a plain return might be better.
> 
> I agree that plain return is better.  Thanks.
> 
> Acked-by: Michael Chan <mchan@...adcom.com>

Applied, thanks.