netdev - Re: [PATCH net-next] Phonet: use rwlock for sockets list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Nov 2009 14:54:38 +0100
From:	Rémi Denis-Courmont <remi@...lab.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org,
	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>
Subject: Re: [PATCH net-next] Phonet: use rwlock for sockets list


On Fri, 06 Nov 2009 14:44:20 +0100, Eric Dumazet <eric.dumazet@...il.com>
wrote:
> Rémi Denis-Courmont a écrit :
>> From: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
>>
>> Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>
>> ---
>>  net/phonet/socket.c |   24 ++++++++++++------------
>>  1 files changed, 12 insertions(+), 12 deletions(-)
> 
> Hmm... rwlocks are bad...

They're in many places throughout the non-IP families...

> Would you care to explain why you introduce a rwlock ?

It seems better than a spinlock, assuming that sockets are
created/destroyed more seldom than they receive packets. And then
sk_for_each_rcu does not exist. I am sure there is a good reason for that,
though I wouldn't know. I guess I should try to use RCU hlist_nulls then?

-- 
Rémi Denis-Courmont

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html