lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Nov 2009 12:04:47 +0100 From: Patrick McHardy <kaber@...sh.net> To: Herbert Xu <herbert@...dor.apana.org.au> CC: Linux Netdev List <netdev@...r.kernel.org>, Jarek Poplawski <jarkao2@...il.com>, "David S. Miller" <davem@...emloft.net>, Stephen Hemminger <shemminger@...tta.com> Subject: Re: RFC: net: allow to propagate errors through ->ndo_hard_start_xmit() Herbert Xu wrote: > On Mon, Nov 09, 2009 at 08:41:36PM +0100, Patrick McHardy wrote: >> - I'm not sure the error handling in dev_hard_start_xmit() for GSO >> skbs is optimal. When the driver returns an error, it is assumed >> the current segment has been freed. The patch then frees the >> entire GSO skb, including all remaining segments. Alternatively >> it could try to transmit the remaining segments later. > > Well driver errors (not queueing errors) should never happen. Yeah, usually there will only be queueing errors. One case for a non-queueing error might be to return EHOSTUNREACH from ipip or gre when there's no route to the peer. > And if they do then they're likely to persist. So freeing the > rest should be sufficient, unless of course if doing it some > other way is simpler :) This way seems simpler. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists