netdev - Re: [PATCH] add HAVE_UNREGISTER_NETDEV_QUEUE define for out-of-tree modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Nov 2009 14:49:16 -0500
From:	Benjamin LaHaise <bcrl@...et.ca>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] add HAVE_UNREGISTER_NETDEV_QUEUE define for out-of-tree modules

On Wed, Nov 11, 2009 at 11:24:57AM -0800, David Miller wrote:
> From: Benjamin LaHaise <bcrl@...et.ca>
> Date: Tue, 10 Nov 2009 17:00:04 -0500
> 
> > I have an out of tree network driver (GPL'd) that would like to make use of 
> > the unregister_netdevice_queue interface for bulk unregister of devices.  
> > Add a #define HAVE_UNREGISTER_NETDEV_QUEUE to allow the source to detect 
> > that the kernel supports this.
> 
> Please get your code upstream :-)

It's a completely separate PPP & L2TP / PPPoE from the existing code that 
is in tree.  Somehow, I don't think people are interested in merging duplicate 
functionality regardless of what differences there are in the interfaces.

> We're already overcluttered with these "HAVE_PANTS", "HAVE_JACKET",
> "HAVE_KITCHEN", "HAVE_SINK" ugly defines spewed all over netdevice.h,
> and I'm not adding any more of that.

If there was some other way of detecting that the interface is present, 
I'd use it, but there isn't.

		-ben
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html