lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Nov 2009 15:47:03 +0100 From: Arnd Bergmann <arnd@...db.de> To: Patrick McHardy <kaber@...sh.net> Cc: Eric Dumazet <eric.dumazet@...il.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Stephen Hemminger <shemminger@...tta.com>, Herbert Xu <herbert@...dor.apana.org.au>, Patrick Mullaney <pmullaney@...ell.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Edge Virtual Bridging <evb@...oogroups.com>, Anna Fischer <anna.fischer@...com>, bridge@...ts.linux-foundation.org, virtualization@...ts.linux-foundation.org, Jens Osterkamp <jens@...ux.vnet.ibm.com>, Gerhard Stenzel <gerhard.stenzel@...ibm.com> Subject: Re: [PATCH 3/3] macvlan: export macvlan mode through netlink On Thursday 19 November 2009, Patrick McHardy wrote: > > +enum ifla_macvlan_mode { > > + MACVLAN_MODE_PRIVATE = 1, /* don't talk to other macvlans */ > > + MACVLAN_MODE_VEPA = 2, /* talk to other ports through ext bridge */ > > + MACVLAN_MODE_BRIDGE = 4, /* talk to bridge ports directly */ > > +}; > > Please also keep the enum named something without ifla_ since > the mode values themselves are not netlink attributes. Just > macvlan_mode seems fine. Ok, good. I was unsure on the naming and also changed between MACVLAN_* and MACVLAN_MODE_* a few times. Thanks for the clarification, Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists