netdev - Re: [PATCH] igb: fix misinterpreted return value of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2009 11:51:24 +0100
From:	Stefan Assmann <sassmann@...hat.com>
To:	Florian Westphal <fw@...len.de>
CC:	netdev <netdev@...r.kernel.org>,
	Andy Gospodarek <gospo@...hat.com>,
	alexander.h.duyck@...el.com, davem@...emloft.net
Subject: Re: [PATCH] igb: fix misinterpreted return value of pci_enable_msix

On 24.11.2009 11:40, Florian Westphal wrote:
> Stefan Assmann <sassmann@...hat.com> wrote:
>> From: Stefan Assmann <sassmann@...hat.com>
>>
>> In the igb driver a return value of 0 of function pci_enable_msix is
>> interpreted as an error case. The correct behaviour is to check < 0 for error
>> values.
>>
>> Signed-off-by: Stefan Assmann <sassmann@...hat.com>
>> ---
>>  drivers/net/igb/igb_main.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
>> index bb1a6ee..745481d 100644
>> --- a/drivers/net/igb/igb_main.c
>> +++ b/drivers/net/igb/igb_main.c
>> @@ -694,7 +694,7 @@ static void igb_set_interrupt_capability(struct igb_adapter *adapter)
>>  	err = pci_enable_msix(adapter->pdev,
>>  			      adapter->msix_entries,
>>  			      numvecs);
>> -	if (err == 0)
>> +	if (err < 0)
>>  		goto out;
>>
> 
> The existing code looks correct to me:
> 
>       if (err == 0)
>             goto out;
> 
>       igb_reset_interrupt_capability(adapter);
> 
>       /* If we can't do MSI-X, try MSI * */
> msi_only:
> 
> 
> so the "goto out" appears to be the "success" case.

Hi Florian,

thanks for pointing this out. I've jumped to conclusions too fast.
There's a problem with igb MSI-X in RHEL5 in the kdump case and this
fixed it for me. But you're right, it's not the proper solution. I'll
report back when I have more information.

  Stefan

--
Stefan Assmann         | Red Hat GmbH
Software Engineer      | Otto-Hahn-Strasse 20, 85609 Dornach
                       | HR: Amtsgericht Muenchen HRB 153243
                       | GF: Brendan Lane, Charlie Peters,
sassmann at redhat.com |     Michael Cunningham, Charles Cachera
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html