netdev - Re: [PATCH] sch_htb: ix the deficit overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Dec 2009 01:20:17 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	xiaosuo@...il.com, hadi@...erus.ca, netdev@...r.kernel.org,
	martin.devera@....cz
Subject: Re: [PATCH] sch_htb: ix the deficit overflows

From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 30 Nov 2009 11:10:20 +0000

> On Mon, Nov 30, 2009 at 12:26:33PM +0800, Changli Gao wrote:
>> And
>> if we use IMQ to shape traffic, the skb will be defragmented by
>> conntrack, and its size will be larger than MTU.
> 
> IMQ is a very nice thing, but it's considered broken as well, so it
> can't be the reason for changing HTB.

If you don't like IMQ, fine.  Simply consider TSO and GSO as another
set of mechanisms that can introduce this condition.

Because we toss large SKBs all over the strack quite freely,
protections like those suggested by Changli make perfect sense.

We really don't have an MTU for packets within our stack any more.
The code, by default, need to be able to handle anything.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html