netdev - Re: KS8851 SPI Driver Integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Dec 2009 12:26:26 -0600
From:	Abraham Arce <abraham.arce.moreno@...il.com>
To:	ben@...tec.co.uk
Cc:	netdev@...r.kernel.org
Subject: Re: KS8851 SPI Driver Integration

Hi,

> I am currently working with ks8851snl driver and facing some issues,
> the system integrated with is OMAP4, a ARM Cortex A9 Dual Core. I am
> using the following commit as latest

I have integrated latest patches from networking tree... driver is
functional with some minor changes at spi and ks8851 level described
below

> * Driver won't be able to get ip address via dhcp if SMP/Preemption/L2
> Cache are enabled, I have not enabled/disabled one by one to narrow
> down the problem...
>

The problem was in in mcspi l2 cache flush operation...

http://dev.omapzoom.org/?p=integration/kernel-omap4.git;a=commit;h=e351961969285d9069fcca9e22f748bb0f20f71d

> * Kernel NULL pointer when trying to mount a nfs directory using
> bootargs or after some time of pinging to any other ip

The following patch needed

http://dev.omapzoom.org/?p=integration/kernel-omap4.git;a=commitdiff;h=dd28c3d44322e98b25e2eb28f51e2e74dffec692

--- a/drivers/net/ks8851.c
+++ b/drivers/net/ks8851.c
@@ -722,12 +722,14 @@ static void ks8851_tx_work(struct work_struct *work)
               txb = skb_dequeue(&ks->txq);
               last = skb_queue_empty(&ks->txq);

-               ks8851_wrreg16(ks, KS_RXQCR, ks->rc_rxqcr | RXQCR_SDA);
-               ks8851_wrpkt(ks, txb, last);
-               ks8851_wrreg16(ks, KS_RXQCR, ks->rc_rxqcr);
-               ks8851_wrreg16(ks, KS_TXQCR, TXQCR_METFE);
+               if (txb != NULL) {
+                       ks8851_wrreg16(ks, KS_RXQCR, ks->rc_rxqcr | RXQCR_SDA);
+                       ks8851_wrpkt(ks, txb, last);
+                       ks8851_wrreg16(ks, KS_RXQCR, ks->rc_rxqcr);
+                       ks8851_wrreg16(ks, KS_TXQCR, TXQCR_METFE);

-               ks8851_done_tx(ks, txb);
+                       ks8851_done_tx(ks, txb);
+               }
       }

       mutex_unlock(&ks->lock);

Best Regards
Abraham
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html