netdev - Re: [PATCH] inetpeer: optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Dec 2009 21:18:24 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH] inetpeer: optimizations

On Sun, Dec 06, 2009 at 07:58:07PM +0100, Eric Dumazet wrote:
> Yes, you miss something. We are not working on a true reference count variable.
> (p is referenced in avl tree but there is no +1 count for this reference)
> 
> Its more a usecount one, and p usecount can be 0 but p still in avl tree.
> 
> Even if we are the thread (A) doing 1 -> 0 transition, other thread (B)
> can find p and perform the opposite 0 -> 1 transition.
> 
> If (B) tries to unlink p before (A), it finds p already unlinked.
> 
> Then (A) links into unused list, while refcnt is still 1

This last thing can happen now too, but as I wrote, my idea was wrong,
nevertheless.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html