netdev - Re: [RFC PATCH 03/12] ixgbe: Add SR-IOV register, structure and bit defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2009 11:06:35 +1100
From:	Simon Horman <horms@...ge.net.au>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	Greg Rose <gregory.v.rose@...el.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [RFC PATCH 03/12] ixgbe: Add SR-IOV register, structure and
 bit defines

On Tue, Dec 08, 2009 at 02:13:51PM -0800, Jeff Kirsher wrote:
> From: Greg Rose <gregory.v.rose@...el.com>
> 
> This patch adds register definitions, bit definitions and structures used by
> the SW to support SR-IOV features of the 82599 controller.
> 
> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
> 
>  drivers/net/ixgbe/ixgbe.h      |   31 +++++++++++++++++++++++++--
>  drivers/net/ixgbe/ixgbe_type.h |   46 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 75 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe.h b/drivers/net/ixgbe/ixgbe.h

[snip]

> @@ -440,6 +466,7 @@ extern s32 ixgbe_atr_set_flex_byte_82599(struct ixgbe_atr_input *input,
>                                           u16 flex_byte);
>  extern s32 ixgbe_atr_set_l4type_82599(struct ixgbe_atr_input *input,
>                                        u8 l4type);
> +extern void ixgbe_set_rx_mode(struct net_device *netdev);
>  #ifdef IXGBE_FCOE
>  extern void ixgbe_configure_fcoe(struct ixgbe_adapter *adapter);
>  extern int ixgbe_fso(struct ixgbe_adapter *adapter,

Making ixgbe_set_rx_mode() non-static in ixgbe_main.c needs to be moved
forward from patch "[RFC PATCH 05/12] ixgbe: Add SR-IOV features to main
module" into this patch to avoid breaking the build.

$ make
...
  CC [M]  drivers/net/ixgbe/ixgbe_main.o
drivers/net/ixgbe/ixgbe_main.c:2402: error: static declaration of 'ixgbe_set_rx_mode' follows non-static declaration
drivers/net/ixgbe/ixgbe.h:470: error: previous declaration of 'ixgbe_set_rx_mode' was here
make[1]: *** [drivers/net/ixgbe/ixgbe_main.o] Error 1
make: *** [_module_drivers/net/ixgbe] Error 2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html