netdev - Re: [Uclinux-dist-devel] [PATCH v3] add the driver for Analog Devices Blackfin on-chip CAN controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2009 05:12:41 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Barry Song <21cnbao@...il.com>
Cc:	Wolfgang Grandegger <wg@...ndegger.com>,
	socketcan-core@...ts.berlios.de,
	uclinux-dist-devel@...ckfin.uclinux.org, davem@...emloft.net,
	"H.J. Oertel" <oe@...t.de>, netdev@...r.kernel.org
Subject: Re: [Uclinux-dist-devel] [PATCH v3] add the driver for Analog Devices 
	Blackfin on-chip CAN controllers

On Thu, Dec 10, 2009 at 05:05, Barry Song wrote:
> On Thu, Dec 10, 2009 at 6:04 PM, Mike Frysinger wrote:
>> On Thu, Dec 10, 2009 at 04:11, Wolfgang Grandegger wrote:
>>> Barry Song wrote:
>>>> +#include <linux/module.h>
>>>> +#include <linux/init.h>
>>>> +#include <linux/kernel.h>
>>>> +#include <linux/types.h>
>>>
>>> I think you don't need "types.h" as the code no longer uses "uint*_t".
>>
>> linux/types.h declares all types, like u* which this driver still uses
>>
>>> Well, I'm still not a friend of the following inline functions,
>>> especially the *one-liners* which are called just *once*. With the usage
>>> of structs they seem even more useless.
>>
>> seems like it would make more sense to not even use the read/write
>> functions either.  just declare the regs as volatile and assign/read
>> the struct directly.
>
> volatile will cause check patch warning in fact.

checkpatch output is not something that needs to be 100% clean.  you
review the output and determine whether it makes sense to fix or
ignore.  in this case, you ignore.
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html