lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Dec 2009 10:13:56 +1000 From: Greg Ungerer <gerg@...pgear.com> To: Baruch Siach <baruch@...s.co.il> CC: Sascha Hauer <s.hauer@...gutronix.de>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 3/4] fec: add support for Freescale i.MX25 PDK (3DS) Hi Baruch, Baruch Siach wrote: > Hi Greg, > > On Tue, Dec 15, 2009 at 09:52:24PM +1000, Greg Ungerer wrote: >> On 12/15/2009 06:31 PM, Baruch Siach wrote: > > [snip] > >>> +#ifndef CONFIG_M5272 >> I would suggest making this conditional on FEC_MIIGSK_ENR. >> Although the CONFIG_M5272 is the only case here currently, >> that may change over the years. And using this here may not >> be obvious to the causual code reader, since the register >> offset definitions don't explicitly key on CONFIG_M5272. > > OK, I'll change this conditional. > > Can I take this as an Ack from you? With that conditional check changed, sure: Acked-by: Greg Ungerer <gerg@...inux.org> Regards Greg >>> + if (fep->phy_interface == PHY_INTERFACE_MODE_RMII) { >>> + /* disable the gasket and wait */ >>> + writel(0, fep->hwp + FEC_MIIGSK_ENR); >>> + while (readl(fep->hwp + FEC_MIIGSK_ENR)& 4) >>> + udelay(1); >>> + >>> + /* configure the gasket: RMII, 50 MHz, no loopback, no echo */ >>> + writel(1, fep->hwp + FEC_MIIGSK_CFGR); >>> + >>> + /* re-enable the gasket */ >>> + writel(2, fep->hwp + FEC_MIIGSK_ENR); >>> + } >>> +#endif > -- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@...pgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists