lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Dec 2009 21:48:27 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: "Michael S. Tsirkin" <mst@...hat.com> Cc: Rusty Russell <rusty@...tcorp.com.au>, Sridhar Samudrala <sri@...ibm.com>, netdev@...r.kernel.org Subject: Re: [RFC PATCH] Regression in linux 2.6.32 virtio_net seen with vhost-net On Wed, Dec 16, 2009 at 03:38:07PM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 16, 2009 at 09:35:12PM +0800, Herbert Xu wrote: > > On Wed, Dec 16, 2009 at 03:22:18PM +0200, Michael S. Tsirkin wrote: > > > > > > Doesn't netif_stop_queue include an atomic op? > > > If yes, does not atomic imply wmb already? > > > > Unfortunately it doesn't. > > So do we need an rmb after testing it as well? You're right. We should have an smp_rmb on the other path. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists