netdev - RE: [RFC PATCH v2 01/12] ixgbevf: Macros, data structures, useful defines and registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Dec 2009 10:51:08 -0800
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: RE: [RFC PATCH v2 01/12] ixgbevf: Macros, data structures, useful
	defines and registers

>-----Original Message-----
>From: Ben Hutchings [mailto:bhutchings@...arflare.com]
>Sent: Monday, December 21, 2009 10:38 AM
>To: Kirsher, Jeffrey T
>Cc: netdev@...r.kernel.org; gospo@...hat.com; Rose, Gregory V
>Subject: Re: [RFC PATCH v2 01/12] ixgbevf: Macros, data structures,
>useful defines and registers
>
>On Fri, 2009-12-18 at 14:51 -0800, Jeff Kirsher wrote:
>> From: Greg Rose <gregory.v.rose@...el.com>
>>
>> These two headers define the commonly used macros, data structures,
>> register bits and register offsets used by the ixgbevf driver on the
>> 82599 virtual function device
>>
>[...]
>> diff --git a/drivers/net/ixgbevf/defines.h
>b/drivers/net/ixgbevf/defines.h
>> new file mode 100644
>> index 0000000..b111771
>> --- /dev/null
>> +++ b/drivers/net/ixgbevf/defines.h
>[...]
>> +/* Check whether address is multicast.  This is little-endian
>specific check.*/
>> +#define IXGBE_IS_MULTICAST(Address) \
>> +	(bool)(((u8 *)(Address))[0] & ((u8)0x01))
>> +
>> +/* Check whether an address is broadcast. */
>> +#define IXGBE_IS_BROADCAST(Address)              \
>> +	((((u8 *)(Address))[0] == ((u8)0xFF)) && \
>> +	 (((u8 *)(Address))[1] == ((u8)0xFF)))
>[...]
>
>Why not use is_multicast_ether_addr() and  is_broadcast_ether_addr()?

This driver was derived from the ixgbe driver and I just copied and pasted those macros from drivers/net/ixgbe/ixgbe_type.h.  We (Intel/LAD) should probably post a patch to fix up both of these at some point.  We'll discuss this amongst ourselves and a patch should be forthcoming, though it may be outside the context of this series of patches.

- Greg


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html