netdev - RE: [RFC PATCH v2 03/12] ixgbevf: Mailbox communication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 Dec 2009 13:38:47 -0800
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: RE: [RFC PATCH v2 03/12] ixgbevf: Mailbox communication

>-----Original Message-----
>From: Ben Hutchings [mailto:bhutchings@...arflare.com]
>Sent: Wednesday, December 23, 2009 12:28 PM
>To: Kirsher, Jeffrey T
>Cc: netdev@...r.kernel.org; gospo@...hat.com; Rose, Gregory V
>Subject: Re: [RFC PATCH v2 03/12] ixgbevf: Mailbox communication
>
>On Fri, 2009-12-18 at 14:51 -0800, Jeff Kirsher wrote:
>> From: Greg Rose <gregory.v.rose@...el.com>
>>
>> The 82599 virtual function device and the master 82599 physical
>function
>> device implement a mailbox utility for communication between the
>devices
>> using some SRAM scratch memory and a doorbell/answering mechanism
>enabled
>> via interrupt and/or polling.  This C module and accompanying header
>> file implement the base functions for use of this feature.
>[...]
>> diff --git a/drivers/net/ixgbevf/mbx.c b/drivers/net/ixgbevf/mbx.c
>> new file mode 100644
>> index 0000000..a6e81fe
>> --- /dev/null
>> +++ b/drivers/net/ixgbevf/mbx.c
>[...]
>> +/**
>> + *  ixgbevf_poll_for_msg - Wait for message notification
>> + *  @hw: pointer to the HW structure
>> + *
>> + *  returns 0 if it successfully received a message notification
>> + **/
>> +static s32 ixgbevf_poll_for_msg(struct ixgbe_hw *hw)
>> +{
>> +	struct ixgbe_mbx_info *mbx = &hw->mbx;
>> +	int countdown = mbx->timeout;
>> +
>> +	if (!mbx->ops.check_for_msg)
>> +		goto out;
>[...]
>
>Can this ever be true?

In this case no.

>Wouldn't that be a bug?

Most definitely.

>
>There are several similar, apparently unnecessary, tests in the
>following functions.

Yeah, the code was derived from a more general purpose code base.  I'll remove these unnecessary tests from the kernel driver.

Regards,

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html