netdev - Re: [RESEND PATCH 1/4] stmmac: thinking about a generic driver for Synopsys Controllers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Dec 2009 18:26:45 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org
Subject: Re: [RESEND PATCH 1/4] stmmac: thinking about a generic driver for
 Synopsys Controllers.

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Wed, 16 Dec 2009 08:26:42 +0100

> The idea behind this patch is to start thinking about a
> generic driver for Synopsys Ethernet Controllers
> starting from the stmmac device driver.

This patch does too much at once.

It changes Kconfig help test.

It moves many things around to many new files.

It's therefore too large to review as a unit.

Please split this up into several (many) pieces.
One for each specific action.

One patch might improve the help test.  Another might
move DMA operations out to a seperate file, another might
move another class of operations into a new file.

And at each step of the way the driver must compile and work
properly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html