netdev - [PATCH] cdc-ether: Assume link is up initially

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Jan 2010 01:26:43 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	speedyboyinovator@...mail.com
Cc:	"David S. Miller" <davem@...emloft.net>,
	"Rafael J. Wysocki" <rjw@...k.pl>, netdev <netdev@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>
Subject: [PATCH] cdc-ether: Assume link is up initially

The bug report <http://bugzilla.kernel.org/show_bug.cgi?id=14791>
implies that at least some devices will not send a Network Connection
notification if the link is initially up.  Further, the CDC-ECM
specification states that '[n]etworking devices are typically "Always
Connected", spending all of their time with the "link up"'.  So it
appears to be safer to assume the link is up and to rely on the device
to tell us otherwise.

This is a partial revert of:

commit 37e8273cd30592d3a82bcb70cbb1bdc4eaeb6b71
Author: Ben Hutchings <ben@...adent.org.uk>
Date:   Wed Nov 4 15:29:52 2009 +0000

    usbnet: Set link down initially for drivers that update link state

Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
Cc: stable@...nel.org
---
This should be tested by someone with one of these devices, preferably
you since you reported the bug.

Ben.

 drivers/net/usb/cdc_ether.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 21e183a..4f27f02 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -419,7 +419,7 @@ static int cdc_manage_power(struct usbnet *dev, int on)
 
 static const struct driver_info	cdc_info = {
 	.description =	"CDC Ethernet Device",
-	.flags =	FLAG_ETHER | FLAG_LINK_INTR,
+	.flags =	FLAG_ETHER,
 	// .check_connect = cdc_check_connect,
 	.bind =		cdc_bind,
 	.unbind =	usbnet_cdc_unbind,
-- 
1.6.5.7


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html