netdev - [PATCH] IPv6: fix rt_lookup in pmtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jan 2010 20:43:48 -0800
From:	Tom Herbert <therbert@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>,
	Lorenzo Colitti <lorenzo@...gle.com>
Subject: [PATCH] IPv6: fix rt_lookup in pmtu_discovery

In rt6_pmtu_discovery a route lookup is done constrained to the
receiving interface of the ICMP message.  In the case of an asymmetric
routing, the receive interface may be different than the sending
interface, so no route will be found in such cases and pmtu is never
correctly set in the route to the destination.  This patch fixes that
by not using the receive interface in the lookup.

Tom

Signed-off-by: Tom Herbert <therbert@...gle.com>

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index df9432a..d7d8893 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1569,7 +1569,7 @@ void rt6_pmtu_discovery(struct in6_addr *daddr,
struct in6_addr *saddr,
        struct net *net = dev_net(dev);
        int allfrag = 0;

-       rt = rt6_lookup(net, daddr, saddr, dev->ifindex, 0);
+       rt = rt6_lookup(net, daddr, saddr, 0, 0);
        if (rt == NULL)
                return;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html