netdev - Re: [net-next-2.6 PATCH 2/5] ixgbe: Make descriptor ring allocations NUMA-aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Jan 2010 00:21:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-next-2.6 PATCH 2/5] ixgbe: Make descriptor ring
 allocations NUMA-aware

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 06 Jan 2010 20:48:46 -0800

> @@ -147,7 +147,7 @@ struct ixgbe_ring {
>  
>  #ifdef CONFIG_IXGBE_DCA
>  	/* cpu for tx queue */
> -	int cpu;
> +	u8 cpu;
>  #endif
>  
>  	u16 work_limit;			/* max work per interrupt */

Is truncating cpu and node numbers to 8-bits ok?  I really don't
see how it can be fine, even for DCA.

This is especially the case since dca3_get_tag() and the
DCA ->get_tag() callback explicitly take an 'int' argument
too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html