lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Jan 2010 00:34:23 -0800 (Pacific Standard Time) From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> To: David Miller <davem@...emloft.net> cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "gospo@...hat.com" <gospo@...hat.com>, "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>, "deri@...p.org" <deri@...p.org>, "Gasparakis, Joseph" <joseph.gasparakis@...el.com> Subject: Re: [net-next-2.6 PATCH 3/5] ethtool: Introduce n-tuple filter programming support On Fri, 8 Jan 2010, David Miller wrote: > From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > Date: Wed, 06 Jan 2010 20:49:06 -0800 > > > @@ -500,6 +529,8 @@ struct ethtool_ops { > > int (*set_rxnfc)(struct net_device *, struct ethtool_rxnfc *); > > int (*flash_device)(struct net_device *, struct ethtool_flash *); > > int (*reset)(struct net_device *, u32 *); > > + int (*set_rx_ntuple)(struct net_device *, struct ethtool_rx_ntuple *); > > + int (*get_rx_ntuple)(struct net_device *, struct ethtool_rx_ntuple *, void *); > > }; > > #endif /* __KERNEL__ */ > > > > @@ -559,6 +590,9 @@ struct ethtool_ops { > > #define ETHTOOL_FLASHDEV 0x00000033 /* Flash firmware to device */ > > #define ETHTOOL_RESET 0x00000034 /* Reset hardware */ > > > > +#define ETHTOOL_SRXNTUPLE 0x00000035 /* Add an n-tuple filter to device */ > > +#define ETHTOOL_GRXNTUPLE 0x00000036 /* Get n-tuple filters from device */ > > + > > Command value ETHTOOL_GRXNTUPLE and the ethtool_ops callback > ->get_rx_ntuple() for it are declared, but I see no implementation > added to net/core/ethtool.c Yes, I left that in there somewhat accidentally. I had every intention in putting a get routine in, but I couldn't come up with a generic way to work with most hardware (how to get all filters back and dump them). The 82599 needs to query the hardware for each filter currently programmed, and I'm not sure what the niu hardware layout is for the filters. I can remove the get stubs for now, since I have no good solution to dump the filters that is generic. Thanks, -PJ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists