netdev - Re: [PATCH] ep93xx_eth.c general cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 08 Jan 2010 00:53:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	hartleys@...ionengravers.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	buytenh@...tstofly.org
Subject: Re: [PATCH] ep93xx_eth.c general cleanup

From: H Hartley Sweeten <hartleys@...ionengravers.com>
Date: Tue, 5 Jan 2010 14:05:31 -0700

> General cleanup of the ep93xx_eth driver.
> 
> 1) Use pr_fmt() to prefix the module name and __func__ to the error 
>    messages.
> 2) <linux/io.h> instead of <asm/io.h>
> 3) <mach/hardware.h> instead of <mach/ep93xx-regs.h> and <mach/platform.h>
> 4) Move the ep93xx_mdio_read (and ep93xx_mdio_write) function to eliminate
>    the function prototype.
> 5) Change all the printk(<level> messages to pr_<level> and remove the 
>    __func__ argument.
> 6) Use platform_get_{resource/irq} to get the platform resources and add
>    an error check.
> 7) Use resource_size() for request_mem_region() and ioremap().
> 8) Use %pM to print the MAC address at the end of the probe.
> 9) Use dev->dev_addr not data->dev_addr for the MAC argument because a
>    random address could be used if the platform does not supply one.
> 
> The message at the end of the probe is left as a printk since it displays
> cleaner without the function name that would be displayed with pr_info().
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Acked-by: Lennert Buytenhek <kernel@...tstofly.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html