netdev - qla3xxx: sleep in atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Jan 2010 13:23:41 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	ron.mercer@...gic.com
CC:	linux-driver@...gic.com, netdev@...r.kernel.org
Subject: qla3xxx: sleep in atomic

Hi,

stanse found a potential sleep inside atomic context. ql_sem_spinlock
must be called with hw_lock which is spinlock (locked with irq disabled
btw.), but ql_sem_spinlock calls ssleep when the HW spinlock cannot be
taken. Could you fix that somehow. E.g. unlock; sleep; lock; if not
called from irq context at all. Or alternatively lower the sleep
interval to usecs and use udelay as it seems it never trigerred (the hw
lock never failed), because people would get deadlocks otherwise.

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html