netdev - RE: [PATCH net-next-2.6 02/13] net-caif: add CAIF header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jan 2010 11:53:16 +0100
From:	Sjur Brændeland <sjur.brandeland@...ricsson.com>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<marcel@...tmann.org>, <stefano.babic@...ic.homelinux.org>,
	<randy.dunlap@...cle.com>
Subject: RE: [PATCH net-next-2.6 02/13] net-caif: add CAIF header files

Hi Patrick.

Patrick McHardy wrote:
> sjur.brandeland@...ricsson.com wrote:
>> +/**
>> + * enum ifla_caif
>> + * When using RT Netlink to create, destroy or configure a CAIF IP
>> +interface, + * enum ifla_caif is used to specify the configuration
>> attributes. + * + * @IFLA_CAIF_IPV4_CONNID:  Connection ID for IPv4
>> PDP Context. + *			    The type of attribute is NLA_U32.
>> + * @IFLA_CAIF_IPV6_CONNID:  Connection ID for IPv6 PDP Context.
>> + *			    The type of attribute is NLA_U32.
>> + * @IFLA_CAIF_LOOPBACK:	    If different from zero, device is doing
>> loopback + *			    The type of attribute is NLA_U8.
>> + */
>> +enum ifla_caif {
>> +	IFLA_CAIF_IPV4_CONNID,
>> +	IFLA_CAIF_IPV6_CONNID,
>> +	IFLA_CAIF_LOOPBACK,
>> +	__IFLA_CAIF_MAX
>> +};
>> +#define	IFLA_CAIF_MAX (__IFLA_CAIF_MAX-1)
>> +
>> +#endif /*IF_CAIF_H_*/
> 
> You should add an IFLA_CAIF_UNSPEC at the beginning, some of the
> nlattr helpers skip attributes with a value of zero. 

OK, thanks. I'll fix this in the next patch set.

BR/Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html