netdev - Re: [2.6.33-rc5 regression] NULL pointer dereference in vlan_skb_recv - probably introduced by commit 9793241fe92f7d9303fb221e43fc598eb065f267

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 24 Jan 2010 20:18:08 +0100
From:	Bruno Prémont <bonbons@...ux-vserver.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Américo Wang <xiyou.wangcong@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6.33-rc5 regression] NULL pointer dereference in
 vlan_skb_recv - probably introduced by commit
 9793241fe92f7d9303fb221e43fc598eb065f267

Yep, works fine and RX stats look right as well.

So
Reported-By: Bruno Prémont <bonbons@...ux-vserver.org>
Tested-By: Bruno Prémont <bonbons@...ux-vserver.org>

Thanks,
Bruno


On Sun, 24 January 2010 Eric Dumazet <eric.dumazet@...il.com> wrote:
> Ok, I believe I found the problem :)
> 
> Please try following patch, if it works I'll submit with appropriate
> Changelog and signatures
> 
> Thanks
> 
> 
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index b788978..c1b92ca 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -163,7 +163,7 @@ int vlan_skb_recv(struct sk_buff *skb, struct net_device *dev,
>               goto err_unlock;
>  	}
>  
> -	rx_stats = per_cpu_ptr(vlan_dev_info(dev)->vlan_rx_stats,
> +	rx_stats = per_cpu_ptr(vlan_dev_info(skb->dev)->vlan_rx_stats,
>                              smp_processor_id());
>       rx_stats->rx_packets++;
>  	rx_stats->rx_bytes += skb->len;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html