netdev - Re: [PATCH net-next-2.6] net: use helpers to access mc list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Feb 2010 07:25:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: use helpers to access mc list

From: Jiri Pirko <jpirko@...hat.com>
Date: Tue, 26 Jan 2010 15:57:39 +0100

> Temporary macro "netdev_for_each_mc_addr" works in the ugly way, I'm aware, but
> it will be replaced. It uses iterator stored in "struct net_device". In every
> iteration, it copies addr from the list to "struct netdev_hw_addr" instance
> (also stored in "struct net_device"). Driver reads address stored in this
> structure. All is protected by addr_list_lock held by a caller.

This kind of ugly hack is rarely necessary, so I'm not applying
this, sorry.

In the macros, use the iterator type the driver instances already use,
which is the mcaddr entry pointer.

Then by using list_for_each_entry() things should "just work".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html