netdev - Re: [PATCH net-next-2.6] net: use helpers to access mc list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2010 17:03:48 +0100
From:	Jiri Pirko <jpirko@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] net: use helpers to access mc list

Tue, Feb 02, 2010 at 04:25:33PM CET, davem@...emloft.net wrote:
>From: Jiri Pirko <jpirko@...hat.com>
>Date: Tue, 26 Jan 2010 15:57:39 +0100
>
>> Temporary macro "netdev_for_each_mc_addr" works in the ugly way, I'm aware, but
>> it will be replaced. It uses iterator stored in "struct net_device". In every
>> iteration, it copies addr from the list to "struct netdev_hw_addr" instance
>> (also stored in "struct net_device"). Driver reads address stored in this
>> structure. All is protected by addr_list_lock held by a caller.
>
>This kind of ugly hack is rarely necessary, so I'm not applying
>this, sorry.

Well, I admit it's ugly but it's only temporary. It would go away once all
drivers would be converted to use it (a matter of weeks/month tops I hope).

>
>In the macros, use the iterator type the driver instances already use,
>which is the mcaddr entry pointer.

You mean "struct dev_mc_list"? But that would solve nothing. If I would still
use current structure in drivers, then still the migration to struct_hw_addr
would be all-at-once for all drivers :( This patch was exacly made to avoid
this.

>
>Then by using list_for_each_entry() things should "just work".

Maybe I do not uderstand you correctly. Would you please explain?

Thanks a lot.

Jirka
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html