netdev - Re: [PATCH net-next-2.6] bonding: Remove net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Feb 2010 13:40:06 -0800
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Ajit Khaparde <ajitk@...verengines.com>
cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] bonding: Remove net_device_stats from bonding struct

Ajit Khaparde <ajitkhaparde@...il.com> wrote:

>There is no need to maintain stats in the bonding structure.
>Use the instance of net_device_stats in netdevice.
>
>Signed-off-by: Ajit Khaparde <ajitk@...verengines.com>

	Note that the accumulation of stats across the slaves is done
into a separate local instance of net_device_stats, so partial results
shouldn't be visible.

Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

	-J

>---
> drivers/net/bonding/bond_main.c |    2 +-
> drivers/net/bonding/bonding.h   |    1 -
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 6221936..1787e3c 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -3742,7 +3742,7 @@ static int bond_close(struct net_device *bond_dev)
> static struct net_device_stats *bond_get_stats(struct net_device *bond_dev)
> {
> 	struct bonding *bond = netdev_priv(bond_dev);
>-	struct net_device_stats *stats = &bond->stats;
>+	struct net_device_stats *stats = &bond_dev->stats;
> 	struct net_device_stats local_stats;
> 	struct slave *slave;
> 	int i;
>diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
>index 558ec13..257a7a4 100644
>--- a/drivers/net/bonding/bonding.h
>+++ b/drivers/net/bonding/bonding.h
>@@ -197,7 +197,6 @@ struct bonding {
> 	s8	 send_grat_arp;
> 	s8	 send_unsol_na;
> 	s8	 setup_by_slave;
>-	struct   net_device_stats stats;
> #ifdef CONFIG_PROC_FS
> 	struct   proc_dir_entry *proc_entry;
> 	char     proc_file_name[IFNAMSIZ];
>-- 
>1.6.3.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html