netdev - Re: [PATCH 02/25 v2] mlx4_core: add support for arbitrary bitmap sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Feb 2010 14:25:47 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Cc:	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	liranl@...lanox.co.il, tziporet@...lanox.co.il
Subject: Re: [PATCH 02/25 v2] mlx4_core: add support for arbitrary bitmap sizes

 > +int mlx4_bitmap_init_no_mask(struct mlx4_bitmap *bitmap, u32 num,
 > +			     u32 reserved_bot, u32 reserved_top)
 > +{
 > +	u32 num_rounded = roundup_pow_of_two(num);
 > +	return mlx4_bitmap_init(bitmap, num_rounded, num_rounded - 1,
 > +				reserved_bot, num_rounded - num + reserved_top);
 > +}

I think I would really prefer things if we got rid of this wrapper.  The
mlx4_bitmap stuff is really there to handle the case where we want to
have a mask and have the non-used bits cycle to avoid reusing QPN etc.
If we have a bitmap with no mask that's no a power of 2 in size, there's
really no value in the mlx4 wrapper -- we might as well just allocate a
bitmap directly.

And since this is only used in one place (for the EQ tables) I think it
makes sense to just open-code everything in the EQ code.

 - R.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html