netdev - Re: [PATCH 2/2] sky2: Allocate initial skbs in sky2_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2010 22:12:46 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Mike McCormack <mikem@...g3k.org>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] sky2: Allocate initial skbs in sky2_alloc_buffers

On Fri, 5 Feb 2010 18:10:45 -0800
Stephen Hemminger <shemminger@...tta.com> wrote:

> On Sat, 06 Feb 2010 10:22:59 +0900
> Mike McCormack <mikem@...g3k.org> wrote:
> 
> > Allocating everything in one place means there's a single point
> > of failure in sky2_up, and sky2_rx_start can no longer fail.
> 
> If ring is never allocated, how then it must fail in up.
> Plus if the initial ring allocation is partial it should fail.

Let me put that clearer...
When dev_open is called, the system might be very short of memory
and unable to allocate the number of receive buffers; in that case,
I would prefer that an error was returned to the application.
Yes, this is a corner case; but it is better to fail with a noisy
error than limp along with a dead device.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html