netdev - Re: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Feb 2010 08:45:15 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	John Linn <John.Linn@...inx.com>
Cc:	netdev@...r.kernel.org, linuxppc-dev@...abs.org, jgarzik@...ox.com,
	jwboyer@...ux.vnet.ibm.com, john.williams@...alogix.com,
	Sadanand Mutyala <sadanan@...inx.com>
Subject: Re: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support

On Mon, Feb 8, 2010 at 7:09 AM, John Linn <John.Linn@...inx.com> wrote:
>> -----Original Message-----
>> From: John Linn [mailto:john.linn@...inx.com]
>> Sent: Friday, February 05, 2010 3:41 PM
>> To: netdev@...r.kernel.org; linuxppc-dev@...abs.org;
> jgarzik@...ox.com; grant.likely@...retlab.ca;
>> jwboyer@...ux.vnet.ibm.com
>> Cc: john.williams@...alogix.com; John Linn; Sadanand Mutyala
>> Subject: [PATCH] [V2] net: emaclite: adding MDIO and phy lib support
>>
>> These changes add MDIO and phy lib support to the driver as the
>> IP core now supports the MDIO bus.
>>
>> The MDIO bus and phy are added as a child to the emaclite in the
> device
>> tree as illustrated below.
>>
>> mdio {
>>       #address-cells = <1>;
>>       #size-cells = <0>;
>>       compatible = "xlnx,emaclite-mdio";
>>       phy0: phy@7 {
>>               reg = <7>;
>>       } ;
>> }

You misunderstood me about the compatible property.  You don't need a
compatible prop in the mdio node because it is *alwasy* a child of the
emaclite node, and the emaclite driver knows to go looking for it (ie.
it is a part of the device).

What I want to see is a compatible value in the phy@7 node for the
make & model of the phy.

Otherwise, looks good to me.  Fix the mutex timeout problem and then
you can add my acked-by line to the patch.

Cheers,
g.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html