lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Feb 2010 09:17:12 -0800 (Pacific Standard Time) From: "Brandeburg, Jesse" <jesse.brandeburg@...el.com> To: Matthew Garrett <mjg@...hat.com> cc: "e1000-devel@...ts.sourceforge.net" <e1000-devel@...ts.sourceforge.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 1/2] e1000e: Only disable ASPM on 82573L devices On Thu, 11 Feb 2010, Matthew Garrett wrote: > The 82537 errata and comment in e1000e_disable_l1aspm both agree that > only 82537L devices are affected. Limit the L1 disable to them. Hi Matthew, its a nitpick, but can you please change the part number to the correct one? it should be s/82537/82573 > Signed-off-by: Matthew Garrett <mjg@...hat.com> > --- > drivers/net/e1000e/netdev.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c > index 57f149b..27eed81 100644 > --- a/drivers/net/e1000e/netdev.c > +++ b/drivers/net/e1000e/netdev.c > @@ -4642,6 +4642,10 @@ static void e1000e_disable_l1aspm(struct pci_dev *pdev) > * Unfortunately this feature saves about 1W power consumption when > * active. > */ > + > + if (pdev->device != E1000_DEV_ID_82573L) > + return; > + > pos = pci_find_capability(pdev, PCI_CAP_ID_EXP); > pci_read_config_word(pdev, pos + PCI_EXP_LNKCTL, &val); > if (val & 0x2) { > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists