netdev - Re: [RFC PATCH net-next 0/7] Add netdev_printk and netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2010 20:12:16 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [RFC PATCH net-next 0/7] Add netdev_printk and netif_printk
 macros

On Fri, 2010-02-12 at 13:10 -0800, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Fri, 12 Feb 2010 12:31:29 -0800 (PST)
> > All applied to net-next-2.6, thanks!
> Hmmm, some build problems:
> 
> drivers/net/atl1e/atl1e_main.c: In function 'atl1e_vlan_rx_register':
> drivers/net/atl1e/atl1e_main.c:322: error: 'struct net_device' has no member named 'adapter'
> drivers/net/atl1e/atl1e_main.c:322: error: 'struct net_device' has no member named 'adapter'
> drivers/net/atl1e/atl1e_main.c: In function 'atl1e_restore_vlan':
> drivers/net/atl1e/atl1e_main.c:343: error: 'struct net_device' has no member named 'adapter'
> drivers/net/atl1e/atl1e_main.c:343: error: 'struct net_device' has no member named 'adapter'
> ...
> 
> Passing in a derference like "adapter->netdev" as an argument doesn't work with these macros
> end up giving us things like:
> 
> 	dev_driver_string((adapter->netdev)->adapter->netdev.parent)
> and
> 	dev_name((adapter->netdev)->adapter->netdev.parent)
> 
> The issue seems to be the netdev_dbg() define when DEBUG is not set and
> CONFIG_DYNAMIC_DEBUG is set.
> 
> It goes "(dev)->dev.parent" and CPP has fun with that.
> 
> I'll use a different name for the first macro argument to netdev_dbg() and see
> if that's enough to fix this.

Hi David.

Been out a couple of days.
I sent it as an RFC not meaning them to be applied.

It's actually the dev_name((dev)->dev. expansion.

I've redone these patches using (netdev) as the argument
to dev_name.

If you want to take the RFC patches, OK, but I could send
a patchset that compiles all cases cleanly.  Want that?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html