netdev - Re: [PATCH -mm] ssb: open-code dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Feb 2010 22:24:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	fujita.tomonori@....ntt.co.jp
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, mb@...sch.de,
	stefano.brivio@...imi.it, Larry.Finger@...inger.net,
	akpm@...ux-foundation.org
Subject: Re: [PATCH -mm] ssb: open-code dma_alloc_coherent

From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Date: Mon, 15 Feb 2010 14:21:58 +0900

> From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> Subject: [PATCH -mm] ssb: open-code dma_alloc_coherent
> 
> This removes ssb_dma_alloc_consistent, a wrapper for
> dma_alloc_coherent and pci_alloc_consistent. dma_alloc_coherent
> internally calls pci_alloc_consistent against pci devices so we always
> use dma_alloc_coherent.
> 
> I prefer to use the DMA API directly instead of creating the ssb_dma_
> API. We have been removing any bus specific DMA APIs.
> 
> One disadvantage of this approach that we lost the debugging ability
> of checking the buggy usage of the DMA API against non DMA-capable ssb
> buses. But I guess that the ssb drivers are mature enough and can cope
> with such change?
> 
> I plan to replace all the ssb_dma API if this approach is fine.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>

I'm fine with this:

Acked-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html