lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Feb 2010 15:44:33 +0200 From: Octavian Purdila <opurdila@...acom.com> To: Cong Wang <amwang@...hat.com> Cc: David Miller <davem@...emloft.net>, Linux Kernel Network Developers <netdev@...r.kernel.org>, Linux Kernel Developers <linux-kernel@...r.kernel.org>, "Eric W. Biederman" <ebiederm@...ssion.com> Subject: Re: [net-next PATCH v4 1/3] sysctl: refactor integer handling proc code On Tuesday 16 February 2010 15:09:51 you wrote: > Octavian Purdila wrote: > > On Tuesday 16 February 2010 10:41:07 you wrote: > >>> +static int proc_skip_wspace(char __user **buf, size_t *size) > >>> +{ > >>> + char c; > >>> + > >>> + while (*size) { > >>> + if (get_user(c, *buf)) > >>> + return -EFAULT; > >>> + if (!isspace(c)) > >>> + break; > >>> + (*size)--; (*buf)++; > >>> + } > >>> + > >>> + return 0; > >>> +} > >> > >> In lib/string.c we have skip_spaces(), I think we can use it > >> here instead of inventing another one. > > > > I'm afraid we can't, skip_spaces does not accept userspace buffers. > > Well, you need to use copy_from_user() before call it. > And how much would you copy? You need to either use a stack buffer and do a loop copy or you would need to copy the whole userspace buffer which means we need to allocate a kernel buffer. I think its much cleaner the way is currently done. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists