netdev - Re: [PATCH net-next 0/7] cxgb4 patches V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Feb 2010 22:30:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dm@...lsio.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/7] cxgb4 patches V2

From: Dimitris Michailidis <dm@...lsio.com>
Date: Thu, 18 Feb 2010 13:24:09 -0800

> 
> This is V2 of the cxgb4 patches.
> 
> Changes since V1:
> - Whitespace fixed as well as some additional checkpatch issues.
> - I removed the CH_* logging wrappers.  I used the new netdev_* in a handful of
>   places but mostly stayed with the dev_* functions.
> - I added some comments to describe the register macro scheme.  As a macro
>   change would involve a rather large number of LOCs I'd really like to avoid
>   changing them.

I also told you to not use the non-standard S_*, V_*, etc. register
naming convention.

If you repost your driver without addressing all of the review
feedback you've received thus far, you are wasting people's time
because they will take time out to review your patches again
only to find that you've haven't fixed everything you've already
been made aware of.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html