lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Feb 2010 23:04:23 -0800 (Pacific Standard Time) From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> To: Jeff Garzik <jeff@...zik.org> cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "gospo@...hat.com" <gospo@...hat.com>, "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> Subject: Re: [ethtool PATCH] ethtool: Support n-tuple filter programming On Wed, 24 Feb 2010, Jeff Garzik wrote: > On 02/04/2010 02:51 AM, Jeff Kirsher wrote: > > From: Peter Waskiewicz<peter.p.waskiewicz.jr@...el.com> > > > > Program underlying ethernet devices with n-tuple flow classification > > filters. > > > > This also adds a new flag to ethtool_flags, allowing n-tuple > > programming to be toggled using the set_flags call. > > > > Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@...el.com> > > Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@...el.com> > > --- > > > > ethtool-copy.h | 35 +++++++++++++ > > ethtool.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > > 2 files changed, 186 insertions(+), 5 deletions(-) > > applied, but two problems remain: > > 1) you failed to document this in the man page. I will expect a patch > to ethtool.8. And you shall have it shortly. My bad. > > 2) you introduced a deviation from the upstream kernel ethtool.h: I see what happened. We moved those two entries in ethtool.h into the #ifdef __KERNEL__ section. I can create a patch for the kernel ethtool.h to move them back to match userspace if that is what folks want. > > > --- ethtool-copy.h 2010-02-24 22:39:21.000000000 -0500 > +++ ../net-next-2.6/include/linux/ethtool.h 2010-02-24 > 22:14:43.000000000 -0500 > @@ -389,8 +389,6 @@ > #define ETHTOOL_RXNTUPLE_ACTION_DROP -1 > }; > > -#define ETHTOOL_MAX_NTUPLE_LIST_ENTRY 1024 > -#define ETHTOOL_MAX_NTUPLE_STRING_PER_ENTRY 14 > struct ethtool_rx_ntuple { > __u32 cmd; > struct ethtool_rx_ntuple_flow_spec fs; > > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists