lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Feb 2010 08:05:19 -0500 From: Jeff Garzik <jeff@...zik.org> To: David Miller <davem@...emloft.net> CC: jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org, gospo@...hat.com, peter.p.waskiewicz.jr@...el.com Subject: Re: [net-next-2.6 PATCH] ethtool: Add n-tuple string length to drvinfo and return it On 02/26/2010 07:20 AM, David Miller wrote: > From: Jeff Kirsher<jeffrey.t.kirsher@...el.com> > Date: Fri, 26 Feb 2010 03:54:20 -0800 > >> From: Peter Waskiewicz<peter.p.waskiewicz.jr@...el.com> >> >> The drvinfo struct should include the number of strings that >> get_rx_ntuple will return. It will be variable if an underlying >> driver implements its own get_rx_ntuple routine, so userspace >> needs to know how much data is coming. >> >> Signed-off-by: Peter P Waskiewicz Jr<peter.p.waskiewicz.jr@...el.com> >> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@...el.com> > > Applied. NAK. Did you even read the patch? We don't increase the size of struct ethtool_drvinfo, _especially_ by sticking struct members into the middle of the struct. What do you think 'reserved' is for??? Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists