netdev - RE: e1000e: Fix build with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Mar 2010 11:57:59 -0600
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	David Miller <davem@...emloft.net>, "rjw@...k.pl" <rjw@...k.pl>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: RE: e1000e: Fix build with CONFIG_PM disabled.

David Miller wrote:
> I had to add the following patch to fix the build after
> your changes.
> 
> Thanks.
> 
> e1000e: Fix build with CONFIG_PM disabled.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  drivers/net/e1000e/netdev.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 79b33c5..b96532a 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -5475,6 +5475,7 @@ static DEFINE_PCI_DEVICE_TABLE(e1000_pci_tbl) =
>  { };
>  MODULE_DEVICE_TABLE(pci, e1000_pci_tbl);
> 
> +#ifdef CONFIG_PM
>  static const struct dev_pm_ops e1000_pm_ops = {
>  	.suspend  = e1000_suspend,
>  	.resume   = e1000_resume,
> @@ -5486,6 +5487,7 @@ static const struct dev_pm_ops e1000_pm_ops = {
>  	.runtime_resume = e1000_runtime_resume,
>  	.runtime_idle = e1000_idle,
>  };
> +#endif
> 
>  /* PCI Device API Driver */
>  static struct pci_driver e1000_driver = {
> --
> 1.6.6.1

But then the driver build fails again when CONFIG_PM_RUNTIME is not set.

drivers/net/e1000e/netdev.c: In function `e1000_runtime_resume`:
drivers/net/e1000e/netdev.c:4807: error: `struct dev_pm_info` has no member named `runtime_auto`

Thanks,
Emil--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html