netdev - Re: [PATCH] r8169: Fix rtl8169_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Mar 2010 14:28:39 +0200
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Oleg Nesterov <oleg@...hat.com>,
	David Miller <davem@...emloft.net>,
	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: Fix rtl8169_rx_interrupt()

Hello,

On (03/17/10 14:54), Eric Dumazet wrote:
> Le mercredi 17 mars 2010 à 12:58 +0200, Sergey Senozhatsky a écrit :
> > Hello,
> > 
> > We did pktgen over LAN testing for several hours:
> > 
> > iftop
> >                        19.1Mb                 38.1Mb                  57.2Mb                 76.3Mb            95.4Mb
> > └──────────────────────┴──────────────────────┴───────────────────────┴──────────────────────┴───────────────────────
> > xxxxxxxx0007t2                               => xxxxxxxxxxxxxx.xxxxx.xxxx.xxx                    0b   3.60Kb  4.28Kb
> >                                              <=                                               92.7Mb  92.7Mb  92.5Mb
> > 
> > ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
> > TX:             cumm:  2.50MB   peak:   57.7Kb                                       rates:   7.71Kb  5.97Kb  10.7Kb
> > RX:                    28.0GB           92.9Mb                                                92.7Mb  92.8Mb  92.6Mb
> > TOTAL:                 28.0GB           92.9Mb                                                92.7Mb  92.8Mb  92.6M
> > 
> > Without any problems.
> > 
> > 
> > As soon as I switched back to localhost "pollution":
> > 
> > [ 7343.999279] ------------[ cut here ]------------
> > [ 7343.999292] WARNING: at net/sched/sch_generic.c:255 dev_watchdog+0xc1/0x125()
> > [ 7343.999295] Hardware name: F3JC                
> > [ 7343.999298] NETDEV WATCHDOG: eth0 (r8169): transmit queue 0 timed out
> > [ 7343.999301] Modules linked in: pktgen ppp_async crc_ccitt ipv6 ppp_generic slhc snd_hwdep snd_hda_codec_si3054 snd_hda_codec_realtek sdhci_pci sdhci snd_hda_intel mmc_core
> > asus_laptop sparse_keymap snd_hda_codec led_class snd_pcm rng_core sg psmouse snd_timer snd_page_alloc i2c_i801 evdev snd soundcore serio_raw r8169 mii usbhid hid uhci_hcd
> > ehci_hcd sr_mod cdrom sd_mod usbcore ata_piix
> > [ 7343.999361] Pid: 4801, comm: kpktgend_0 Tainted: G        W  2.6.34-rc1-dbg-git6-r8169 #47
> > [ 7343.999364] Call Trace:
> > [ 7343.999372]  [<c102e293>] warn_slowpath_common+0x65/0x7c
> > [ 7343.999378]  [<c126ac34>] ? dev_watchdog+0xc1/0x125
> > [ 7343.999383]  [<c102e2de>] warn_slowpath_fmt+0x24/0x27
> > [ 7343.999388]  [<c126ac34>] dev_watchdog+0xc1/0x125
> > [ 7343.999395]  [<c1036afb>] ? run_timer_softirq+0x120/0x1eb
> > [ 7343.999401]  [<c1036b51>] run_timer_softirq+0x176/0x1eb
> > [ 7343.999406]  [<c1036afb>] ? run_timer_softirq+0x120/0x1eb
> > [ 7343.999411]  [<c126ab73>] ? dev_watchdog+0x0/0x125
> > [ 7343.999417]  [<c1032d39>] __do_softirq+0x8d/0x117
> > [ 7343.999422]  [<c1032dee>] do_softirq+0x2b/0x43
> > [ 7343.999426]  [<c1032f13>] irq_exit+0x38/0x75
> > [ 7343.999433]  [<c1014e75>] smp_apic_timer_interrupt+0x66/0x74
> > [ 7343.999438]  [<c12c770a>] apic_timer_interrupt+0x36/0x3c
> > [ 7343.999447]  [<f80878df>] ? pktgen_thread_worker+0x5c4/0x631 [pktgen]
> > [ 7343.999454]  [<c103f931>] ? autoremove_wake_function+0x0/0x2f
> > [ 7343.999459]  [<c103f931>] ? autoremove_wake_function+0x0/0x2f
> > [ 7343.999465]  [<f808731b>] ? pktgen_thread_worker+0x0/0x631 [pktgen]
> > [ 7343.999470]  [<c103f60e>] kthread+0x6a/0x6f
> > [ 7343.999476]  [<c103f5a4>] ? kthread+0x0/0x6f
> > [ 7343.999481]  [<c1002e42>] kernel_thread_helper+0x6/0x1a
> > [ 7343.999485] ---[ end trace a22d306b065d4a68 ]---
> > [ 7344.012654] r8169 0000:02:00.0: eth0: link up
> > [ 7356.012657] r8169 0000:02:00.0: eth0: link up
> > [ 7368.013545] r8169 0000:02:00.0: eth0: link up
> > 
> > 
> 
> What do you exactly mean by 'localhost pollution' ?
> 
Sorry. I mean pktgen started on localhost with src set to localhost (not pktgen over LAN from another machine).


	Sergey

Content of type "application/pgp-signature" skipped