netdev - bug in bonding driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Mar 2010 12:23:47 -0600
From:	"Chris Friesen" <cfriesen@...tel.com>
To:	netdev@...r.kernel.org, fubar@...ibm.com,
	bonding-devel@...ts.sourceforge.net
Subject: bug in bonding driver

Hi,

One of our guys pointed out what appears to be a bug in
bond_ab_arp_inspect().  There's a chunk of code that looks like this:

	/*
	 * Give slaves 2*delta after being enslaved or made
	 * active.  This avoids bouncing, as the last receive
	 * times need a full ARP monitor cycle to be updated.
	 */
	if (!time_after_eq(jiffies, slave->jiffies +
			   2 * delta_in_ticks))
		continue;

The catch here is that slave->jiffies may not ever get updated after
being set initially, and on long-running systems jiffies will overflow.
 That could cause this check to be true for a substantial amount of time
rather than for just a short period.

One way to fix it would be a boolean which tracks whether or not we've
gone past the time, and if we have then we don't bother actually
checking the time anymore.

Chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html