netdev - Re: [PATCH 2/2] ipv4: Restart rt_intern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Mar 2010 10:44:13 +0300
From:	Pavel Emelyanov <xemul@...nvz.org>
To:	Neil Horman <nhorman@...driver.com>
CC:	David Miller <davem@...emloft.net>,
	Eric Dumazet <dada1@...mosbay.com>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] ipv4: Restart rt_intern_hash after emergency rebuild

>> @@ -1217,6 +1217,12 @@ restart:
>>  					rt->u.dst.dev->name, num);
>>  			}
>>  			rt_emergency_hash_rebuild(net);
>> +			spin_unlock_bh(rt_hash_lock_addr(hash));
>> +
>> +			hash = rt_hash(rt->fl.fl4_dst, rt->fl.fl4_src,
>> +					in ? rt->fl.iif : rt->fl.oif,
>> +					rt_genid(net));
>> +			goto restart;
>>  		}
>>  	}
> Why pass in a flag here?  Perhaps it would be easier just to pass in the ifindex
> that was origionally used by the caller of rt_intern_hash so that the hash could
> be redone without needing to toggle on the value of the flag.  

That's perfectly fine with me. I'll resend the patch shortly.

> Regards
> Neil
> 
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html