lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Mar 2010 20:45:30 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Timo Teräs <timo.teras@....fi> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH RFC 1/2] flow: virtualize get and entry deletion methods On Mon, Mar 29, 2010 at 03:33:57PM +0300, Timo Teräs wrote: > > So we fix up all the callers of xfrm_policy_kill to check properly > result of __xfrm_policy_unlink(). Since the policy can be only > once deleted from the hashes (it's protected by xfrm_policy_lock) > return value of __xfrm_policy_unlink() can be used to give > responsibility of calling xfrm_policy_kill() exactly once. > > I thought this was already being done, but apparently it's not > the case. Actually you're right. This should be the case as otherwise we'd be triggering that WARN_ON. Since it hasn't triggered in the five years that it's been around, I suppose we can now remove it along with the lock. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists