netdev - Re: [PATCH] Allow MACB to connect to a higher addresses PHY.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Mar 2010 08:41:43 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Anders Darander <anders.darander@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Maxime Bizon <mbizon@...ebox.fr>,
	Anders Darander <ad@...arespons.se>,
	David Daney <ddaney@...iumnetworks.com>,
	Sekhar Nori <nsekhar@...com>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Andy Fleming <afleming@...escale.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Allow MACB to connect to a higher addresses PHY.

On Tue, Mar 30, 2010 at 3:58 AM, Anders Darander
<anders.darander@...il.com> wrote:
> From: Anders Darander <ad@...arespons.se>
>
> Using the Atmel MACB together with an integrated switch, can make only port 1
> work. This is caused by macb_mii_probe trying to attach the MAC to the first
> PHY, which often is on one of the external ports.
>
> E.g. the Micrel KSZ8873 connects to the MAC on port 3, thus phy_addr should be
> set to 3.
>
> Signed-off-by: Anders Darander <ad@...arespons.se>

Hi Anders,

I understand what you are trying to do, but this is the wrong way to
go about it.  Hard coding it into Kconfig breaks multiplatform
kernels.  Besides, systems may have more than one physical MDIO bus.
This patch would make CONFIG_SWITCHING_PHY_ADDR the only address
accessible on all MDIO busses.

Nak.

The right thing to do is to add a runtime configuration option (ie.
kernel parameter or platform data) to the mac driver to specify
exactly which PHY address it is supposed to use.

g.

> ---
>  drivers/net/phy/Kconfig      |   19 ++++++++++++++++++-
>  drivers/net/phy/phy_device.c |    4 ++++
>  2 files changed, 22 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index fc5938b..64aa003 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -15,11 +15,28 @@ if PHYLIB
>
>  comment "MII PHY device drivers"
>
> +config SWITCHING_PHY
> +       bool "An Ethernet switch is connected to the MAC"
> +       depends on MACB
> +       help
> +         If an Ethernet switch is connected to the MAC, it
> +         is quite common to have the connection on a port
> +         higher than the first port. This option allows to
> +         select the desired port number
> +
> +config SWITCHING_PHY_ADDR
> +       int "PHYA address"
> +       depends on SWITCHING_PHY
> +       default "3"
> +       help
> +         On e.g. the Micrel KSZ8873MLL, port 3 (and thus phy_addr
> +         3) is the one connected to the MAC of the MCU.
> +
>  config MARVELL_PHY
>        tristate "Drivers for Marvell PHYs"
>        ---help---
>          Currently has a driver for the 88E1011S
> -
> +
>  config DAVICOM_PHY
>        tristate "Drivers for Davicom PHYs"
>        ---help---
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index db17945..891bd0d 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -284,7 +284,11 @@ struct phy_device *phy_find_first(struct mii_bus *bus)
>  {
>        int addr;
>
> +#ifdef CONFIG_SWITCHING_PHY
> +       for (addr = CONFIG_SWITCHING_PHY_ADDR; addr < PHY_MAX_ADDR; addr++) {
> +#else
>        for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> +#endif
>                if (bus->phy_map[addr])
>                        return bus->phy_map[addr];
>        }
> --
> 1.7.0.3
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html